Thanks for your first contribution @rahulruikar!

There is a build failure:

    [ERROR] 
/scratch/jenkins/workspace/jclouds-labs-pull-requests/cloudsigma2/src/test/java/org/jclouds/cloudsigma2/functions/DriveToJsonTest.java:[72,13]
 jobs(java.util.List<java.util.Map<java.lang.String,java.lang.String>>)
    in org.jclouds.cloudsigma2.domain.DriveInfo.Builder
    cannot be applied to (java.util.ArrayList<java.lang.String>)

Could you fix the builder too?

Apart from that, let me suggest a bit different approach:
The list of jobs (int he JSON response returned by CloudSigma) is in the form:
```json
"jobs": [
  {
    "resource_uri": "/api/2.0/jobs/933133a2-4ee2-4310-9a63-c8d5e7052335/",
    "uuid": "933133a2-4ee2-4310-9a63-c8d5e7052335"
  }
]
```

And although it would be possible to deserialize it in a list of maps, perhaps 
it would be better to deserialize it in a list of `Job` objects. I would create 
a `Job` class in the `domain package` containing the two fields that appear in 
the json, and make the `DriveInfo` object have a list of Jobs instead of a list 
of Maps. WDYT?

Thanks for your contribution!

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs/pull/67#issuecomment-44517543

Reply via email to