Thanks for the changes @rahulruikar! A couple general comments to complete the 
pull request, apart from the previous ones:

- [ ] The jclouds style uses a 3 space indent (no tabs) and a 120 line length. 
Could you format your code accordingly?
- [ ] Run `mvn checkstyle:checkstyle` in the `cloudsigma2` project and make 
sure there are no checkstyle violations.
- [ ] To properly test the change, the corresponding Expect test should be also 
changed:
  - [ ] Modify the 
[drives-single.json](https://github.com/jclouds/jclouds-labs/blob/master/cloudsigma2/src/test/resources/drives-single.json#L9)
 and add some jobs there. The file contains a "mock" response that is used in 
tests to verify responses can be properly parsed.
  - [ ] Modify the 
[CloudSigma2ApiExpectTest#testGetDriveInfo](https://github.com/jclouds/jclouds-labs/blob/master/cloudsigma2/src/test/java/org/jclouds/cloudsigma2/CloudSigma2ApiExpectTest.java#L203)
 test to use that `drives-single.json` (now the test is not properly 
configured), and add some assertions to the test to verify the returned object 
contains the jobs you configured in the mock json.

We're almost there! Thanks!

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs/pull/67#issuecomment-44627135

Reply via email to