> @@ -393,7 +393,8 @@ public void suspendNode(String name) {
> private LoginCredentials
> getFromImageAndOverrideIfRequired(org.jclouds.compute.domain.Image image,
>
> GoogleComputeEngineTemplateOptions options) {
> LoginCredentials defaultCredentials = image.getDefaultCredentials();
> - String[] keys = defaultCredentials.getPrivateKey().split(":");
> + // Atthis point the private key must exist
> + String[] keys =
> defaultCredentials.getOptionalPrivateKey().get().split(":");
This is fine, but I will sidebar: particularly with java8 having optional, I
feel we should divest or at least stop proliferating this type. Nullable is
fine. I don't want to get to a very long debate about it, just raising my
opinion on the matter.
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs-google/pull/62/files#r19255781
