> @@ -171,7 +170,7 @@ public boolean removeSecurityGroup(String id) {
>
> ListOptions options = new ListOptions.Builder().filter("network eq
> .*/" + id);
>
> - FluentIterable<Firewall> fws =
> api.getFirewallApiForProject(userProject.get()).list(options).concat();
> + FluentIterable<Firewall> fws =
> api.getFirewallApiForProject(userProject.get()).list(options).toPagedIterable().concat();
I'd prefer `FluentIterable.from(api...concat());` or
`FluentIterable.from(api...flatten());` I think we should stop proliferating
FluentIterable as it can easily wrap things and reduce the surface area we have
wrt guava compatibility. (again. not interested in an angry debate with people,
just offering advice).
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs-google/pull/62/files#r19255921
