Although the ComputeService methods are called suspend/resume, they could 
perfectly map to the stop/start instance operations, given that we already [map 
the STOPPED state to 
SUSPENDED](https://github.com/jclouds/jclouds-labs-google/blob/master/google-compute-engine/src/main/java/org/jclouds/googlecomputeengine/compute/config/GoogleComputeEngineServiceContextModule.java#L177).
 This would also fix the issue expressed in [this stackoverflow 
question](https://github.com/jclouds/jclouds-labs-google/blob/master/google-compute-engine/src/main/java/org/jclouds/googlecomputeengine/compute/config/GoogleComputeEngineServiceContextModule.java#L177).

This is a WIP, as the `testSuspendResume` live test is failing 
[here](https://github.com/jclouds/jclouds/blob/master/compute/src/test/java/org/jclouds/compute/internal/BaseComputeServiceLiveTest.java#L598).
 @danbroudy could you help debugging and fixing this test?

Note that this PR also fixes several ComputeServiceLiveTests that were not 
being executed and depends on https://github.com/jclouds/jclouds/pull/753 to 
fix the authorization live test.
You can view, comment on, or merge this pull request online at:

  https://github.com/jclouds/jclouds-labs-google/pull/141

-- Commit Summary --

  * Add support to start and stop instances in the ComputeService

-- File Changes --

    M 
google-compute-engine/src/main/java/org/jclouds/googlecomputeengine/compute/GoogleComputeEngineServiceAdapter.java
 (8)
    M 
google-compute-engine/src/main/java/org/jclouds/googlecomputeengine/compute/functions/Resources.java
 (14)
    M 
google-compute-engine/src/test/java/org/jclouds/googlecomputeengine/compute/GoogleComputeEngineServiceLiveTest.java
 (58)
    M 
google-compute-engine/src/test/java/org/jclouds/googlecomputeengine/compute/GoogleComputeEngineServiceMockTest.java
 (2)
    A 
google-compute-engine/src/test/java/org/jclouds/googlecomputeengine/compute/functions/ResourcesMockTest.java
 (126)
    D 
google-compute-engine/src/test/resources/GoogleComputeEngineServiceExpectTest/firewall_list.json
 (36)
    D 
google-compute-engine/src/test/resources/GoogleComputeEngineServiceExpectTest/network_get.json
 (10)
    A google-compute-engine/src/test/resources/test (27)

-- Patch Links --

https://github.com/jclouds/jclouds-labs-google/pull/141.patch
https://github.com/jclouds/jclouds-labs-google/pull/141.diff

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs-google/pull/141

Reply via email to