Many thanks @abayer, you rock! I've applied your fix and the tests are passing
now. I've already squashed the commits and amended the message to include the
jira issue reference.
The node status change was not trivial, though. I've had to change the
"orphaned groups" predicate to consider unexisting nodes instead of nodes in
TERMINATED state, and the GoogleComputeEngineService too. The
"cleanupIncidentalResources" assumes that terminated nodes are also returned by
the API, so I had to fix that too. Anyway everything seems to be in place now.
Any feedback is welcome!
There are two unrelated test faliures, though (but I'll merge the PR anyway as
they are not related to this change):
```
-------------------------------------------------------------------------------
Test set: TestSuite
-------------------------------------------------------------------------------
Tests run: 155, Failures: 2, Errors: 0, Skipped: 5, Time elapsed: 2,686.911 sec
<<< FAILURE! - in TestSuite
testValidateUrlMap(org.jclouds.googlecomputeengine.features.UrlMapApiLiveTest)
Time elapsed: 1.465 sec <<< FAILURE!
java.lang.AssertionError: expected
[UrlMapValidateResult{result=UrlMapValidateResultInternal{loadSucceeded=true,
loadErrors=null, testPassed=true, testFailures=null}}] but found
[UrlMapValidateResult{result=UrlMapValidateResultInternal{loadSucceeded=true,
loadErrors=null, testPassed=false, testFailures=[TestFailure{host=jclouds-test,
path=/test/path,
expectedService=https://www.googleapis.com/compute/v1/projects/jclouds-dev/global/backendServices/url-map-api-live-test-backend-service,
actualService=url-map-api-live-test-backend-service}]}}]
at org.testng.Assert.fail(Assert.java:94)
at org.testng.Assert.failNotEquals(Assert.java:494)
at org.testng.Assert.assertEquals(Assert.java:123)
at org.testng.Assert.assertEquals(Assert.java:165)
at
org.jclouds.googlecomputeengine.features.UrlMapApiLiveTest.testValidateUrlMap(UrlMapApiLiveTest.java:151)
testValidateUrlMapWithOptions(org.jclouds.googlecomputeengine.features.UrlMapApiLiveTest)
Time elapsed: 0.71 sec <<< FAILURE!
java.lang.AssertionError: expected
[UrlMapValidateResult{result=UrlMapValidateResultInternal{loadSucceeded=true,
loadErrors=null, testPassed=true, testFailures=null}}] but found
[UrlMapValidateResult{result=UrlMapValidateResultInternal{loadSucceeded=true,
loadErrors=null, testPassed=false, testFailures=[TestFailure{host=jclouds-test,
path=/test/path,
expectedService=https://www.googleapis.com/compute/v1/projects/jclouds-dev/global/backendServices/url-map-api-live-test-backend-service,
actualService=url-map-api-live-test-backend-service}]}}]
at org.testng.Assert.fail(Assert.java:94)
at org.testng.Assert.failNotEquals(Assert.java:494)
at org.testng.Assert.assertEquals(Assert.java:123)
at org.testng.Assert.assertEquals(Assert.java:165)
at
org.jclouds.googlecomputeengine.features.UrlMapApiLiveTest.testValidateUrlMapWithOptions(UrlMapApiLiveTest.java:180)
```
It looks like an inconsistency with an expected service name, but I completely
ignore how the url map stuff works. @danbroudy could you have a look at these
failures?
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs-google/pull/141#issuecomment-109552960
