> it's poor form to decline or delay a PR such as this on the basis that we 
> would like to see yet further improvements to the original code.

Agree. But we've never had the intention to decline or delay this PR.

Pull requests and code reviews are **conversations** between the contributor 
and the committers. Contributors propose changes, committers make 
recommendations, and also ask for clarifications or feedback. My comment wasn't 
an imposition. It was just a question; an exchange of opinions that could be 
easily replied as you've already done.

Just opening a pull request and ignoring review comments or avoiding 
interaction with the reviewers gives the impression that there is little 
interest in the review, and that's why this PR may have been in standby since 
now that the review conversation is moving on.

I'm happy to merge the PR as-is, but please, understand that the review process 
is a conversation where the two parts need to interact and, as such, I don't 
feel like unilaterally merging PRs when the review conversations are still open 
is the right procedure to follow.

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/907#issuecomment-193735039

Reply via email to