Interesting perspective. In the perfect code review process I agree, but the best is the enemy of the good as someone was fond of saying.
I'd like to float a more pragmatic approach. Sometimes a contributor goes quiet -- probably because of other pressures, nothing personal. It was nice we got something from them. If it's good enough to merge -- even with review comments ignored -- then it's in the interest of our users and the community to merge it. Maybe with a wee comment to nudge the contributor in case they want to give a follow-up PR addressing the ignored comments. (Clearly if it's incomplete or high-risk this doesn't apply, but I agree #677 is another good example.) If a few minor review comments get ignored sometimes but bugs are being squashed, that's a better outcome than bugs staying around until they bite someone else who is also willing to give up their time to fix it. (And I'd wager that for every person who gives a fix there are many more who got hit with the problem and never told us.) Just food for thought... Thanks for merging. :) --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/907#issuecomment-194065700
