roded commented on a change in pull request #64: JCLOUDS-1520 - Reuse
SSLSocketFactory in JavaUrlHttpCommandExecutorSe…
URL: https://github.com/apache/jclouds/pull/64#discussion_r390828189
##########
File path:
core/src/main/java/org/jclouds/http/internal/JavaUrlHttpCommandExecutorService.java
##########
@@ -72,6 +74,7 @@
protected Supplier<SSLContext> sslContextSupplier;
protected final int outputSocketBufferSize;
protected final String userAgent;
+ protected final AtomicReference<SSLSocketFactory> sslSocketFactoryReference;
Review comment:
I don't think I can use the existing suppliers to return a singleton socket
factory, SSLContext is not an interface I can easily implement. I could change
all Supplier<SSLContext>s to Supplier<SSLSocketFactory>s, that way the supplier
implementation could contain the state.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
