nacx commented on a change in pull request #64: JCLOUDS-1520 - Reuse
SSLSocketFactory in JavaUrlHttpCommandExecutorSe…
URL: https://github.com/apache/jclouds/pull/64#discussion_r393162561
##########
File path:
core/src/main/java/org/jclouds/http/internal/JavaUrlHttpCommandExecutorService.java
##########
@@ -72,6 +74,7 @@
protected Supplier<SSLContext> sslContextSupplier;
protected final int outputSocketBufferSize;
protected final String userAgent;
+ protected final AtomicReference<SSLSocketFactory> sslSocketFactoryReference;
Review comment:
My main concern here is that the `JavaUrlHttpCommandExecutorService` is a
singleton, and setting a member variable once will set its value for the entire
lifecycle of the jclouds context. That means, every HTTP connection to any API
method. Is this the intended behavior?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
