pan3793 commented on code in PR #4078:
URL: https://github.com/apache/kyuubi/pull/4078#discussion_r1061222498
##########
bin/kyuubi:
##########
@@ -48,6 +49,7 @@ function kyuubi_rotate_log() {
num=${KYUUBI_MAX_LOG_FILES}
else
echo "Error: KYUUBI_MAX_LOG_FILES must be a positive number, but got
${KYUUBI_MAX_LOG_FILES}"
+ # shellcheck disable=SC2242
exit -1
Review Comment:
> the shell script has many grammar mistake
the shell script grammar is flexible; some are style issues, and should not
be treated as bug/mistake, because they have worked as expected.
> ... fix these bug in issue https://github.com/apache/kyuubi/issues/4057
before do this shellcheck
w/o shellcheck, how to verify the fix?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
