pan3793 commented on code in PR #4078:
URL: https://github.com/apache/kyuubi/pull/4078#discussion_r1062167863
##########
bin/kyuubi:
##########
@@ -48,6 +49,7 @@ function kyuubi_rotate_log() {
num=${KYUUBI_MAX_LOG_FILES}
else
echo "Error: KYUUBI_MAX_LOG_FILES must be a positive number, but got
${KYUUBI_MAX_LOG_FILES}"
+ # shellcheck disable=SC2242
exit -1
Review Comment:
sgtm
##########
.github/workflows/style.yml:
##########
@@ -100,3 +100,12 @@ jobs:
echo "If there is a problem that cannot be fixed by the command, "
echo "you need to manually fix it by following the information told
by the command above"
echo
"---------------------------------------------------------------------------------"
+ shellcheck:
Review Comment:
```suggestion
shellcheck:
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
