ulysses-you commented on code in PR #4081:
URL: https://github.com/apache/kyuubi/pull/4081#discussion_r1061280895
##########
kyuubi-server/src/main/antlr4/org/apache/kyuubi/sql/KyuubiTrinoFeBaseParser.g4:
##########
@@ -26,13 +26,42 @@ singleStatement
statement
: SELECT TABLE_SCHEM COMMA TABLE_CATALOG FROM SYSTEM_JDBC_SCHEMAS
(WHERE (TABLE_CATALOG EQ catalog=STRING+)? AND? (TABLE_SCHEM LIKE
schema=STRING+)?)?
Review Comment:
we can change this to use the new pattern
##########
kyuubi-server/src/main/antlr4/org/apache/kyuubi/sql/KyuubiTrinoFeBaseParser.g4:
##########
@@ -26,13 +26,42 @@ singleStatement
statement
: SELECT TABLE_SCHEM COMMA TABLE_CATALOG FROM SYSTEM_JDBC_SCHEMAS
(WHERE (TABLE_CATALOG EQ catalog=STRING+)? AND? (TABLE_SCHEM LIKE
schema=STRING+)?)?
- ORDER BY TABLE_CATALOG COMMA TABLE_SCHEM
#getSchemas
- | SELECT TABLE_CAT FROM SYSTEM_JDBC_CATALOGS ORDER BY TABLE_CAT
#getCatalogs
- | SELECT TABLE_TYPE FROM SYSTEM_JDBC_TABLE_TYPES ORDER BY TABLE_TYPE
#getTableTypes
+ ORDER BY TABLE_CATALOG COMMA TABLE_SCHEM
#getSchemas
+ | SELECT TABLE_CAT FROM SYSTEM_JDBC_CATALOGS ORDER BY TABLE_CAT
#getCatalogs
+ | SELECT TABLE_TYPE FROM SYSTEM_JDBC_TABLE_TYPES ORDER BY TABLE_TYPE
#getTableTypes
| SELECT TYPE_NAME COMMA DATA_TYPE COMMA PRECISION COMMA LITERAL_PREFIX
COMMA
LITERAL_SUFFIX COMMA CREATE_PARAMS COMMA NULLABLE COMMA CASE_SENSITIVE
COMMA
SEARCHABLE COMMA UNSIGNED_ATTRIBUTE COMMA FIXED_PREC_SCALE COMMA
AUTO_INCREMENT
COMMA LOCAL_TYPE_NAME COMMA MINIMUM_SCALE COMMA MAXIMUM_SCALE COMMA
SQL_DATA_TYPE
- COMMA SQL_DATETIME_SUB COMMA NUM_PREC_RADIX FROM SYSTEM_JDBC_TYPES ORDER
BY DATA_TYPE #getTypeInfo
- | .*?
#passThrough
+ COMMA SQL_DATETIME_SUB COMMA NUM_PREC_RADIX FROM SYSTEM_JDBC_TYPES ORDER
BY DATA_TYPE #getTypeInfo
+ | SELECT TABLE_CAT COMMA TABLE_SCHEM COMMA TABLE_NAME COMMA TABLE_TYPE
COMMA REMARKS COMMA
+ TYPE_CAT COMMA TYPE_SCHEM COMMA TYPE_NAME COMMA
SELF_REFERENCING_COL_NAME COMMA REF_GENERATION
+ FROM SYSTEM_JDBC_TABLES
+ (WHERE tableCatalogFilter? AND? tableSchemaFilter? AND? tableNameFilter?
AND? tableTypeFilter?)?
+ ORDER BY TABLE_TYPE COMMA TABLE_CAT COMMA TABLE_SCHEM COMMA TABLE_NAME
#getTables
+ | .*?
#passThrough
+ ;
+
+
+tableCatalogFilter
+ : TABLE_CAT IS NULL
#nulCatalog
Review Comment:
nulCatalog -> nullCatalog ?
##########
kyuubi-server/src/main/antlr4/org/apache/kyuubi/sql/KyuubiSqlBaseLexer.g4:
##########
@@ -59,12 +59,15 @@ GTE : '>=' | '!<';
LEFT_PAREN: '(';
RIGHT_PAREN: ')';
OR: 'OR';
+SEARCH_STRING_ESCAPE: '\\\'' '\\\\' '\\\'';
Review Comment:
should it be `'\'\\\''` to match `'\'` ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
