ulysses-you commented on code in PR #4081:
URL: https://github.com/apache/kyuubi/pull/4081#discussion_r1061298281


##########
kyuubi-server/src/main/antlr4/org/apache/kyuubi/sql/KyuubiSqlBaseLexer.g4:
##########
@@ -59,12 +59,15 @@ GTE : '>=' | '!<';
 LEFT_PAREN: '(';
 RIGHT_PAREN: ')';
 OR: 'OR';
+SEARCH_STRING_ESCAPE: '\\\'' '\\\\' '\\\'';

Review Comment:
   I test it locally, it print `'\'`
   ```java
   public static void main(String[] args) {
     StringBuilder b = new StringBuilder();
     quoteStringLiteral(b, "\\");
     System.out.println(b.toString());
   }
   
   private static void quoteStringLiteral(StringBuilder out, String value)
   {
     out.append('\'');
     for (int i = 0; i < value.length(); i++) {
        char c = value.charAt(i);
        out.append(c);
        if (c == '\'') {
           out.append('\'');
        }
     }
     out.append('\'');
   }
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to