pan3793 commented on code in PR #5082:
URL: https://github.com/apache/kyuubi/pull/5082#discussion_r1270883638
##########
externals/kyuubi-flink-sql-engine/src/main/java/org/apache/flink/client/deployment/application/executors/EmbeddedExecutorFactory.java:
##########
@@ -105,6 +114,24 @@ public boolean isCompatibleWith(final Configuration
configuration) {
public PipelineExecutor getExecutor(final Configuration configuration) {
checkNotNull(configuration);
Collection<JobID> executorJobIDs;
+ synchronized (bootstrapLock) {
Review Comment:
Emm... I'm not sure I get the idea.
If the code reaches here and `bootstrapJobIds == null` is true, another
thread has no opportunity to initialize the static variables since they are
waiting for the `bootstrapLock` to be released.
I suppose we should use a `CountDownLatch` here instead, to avoid blocking
other threads to initialize the variables.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
