link3280 commented on code in PR #5082:
URL: https://github.com/apache/kyuubi/pull/5082#discussion_r1271237907
##########
externals/kyuubi-flink-sql-engine/src/main/java/org/apache/flink/client/deployment/application/executors/EmbeddedExecutorFactory.java:
##########
@@ -105,6 +114,24 @@ public boolean isCompatibleWith(final Configuration
configuration) {
public PipelineExecutor getExecutor(final Configuration configuration) {
checkNotNull(configuration);
Collection<JobID> executorJobIDs;
+ synchronized (bootstrapLock) {
Review Comment:
IMH, if `bootstrapJobIds == null`, the current thread would release the lock
and wait for `bootstrapLock.notifyAll()` to be called by the bootstrap thread.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
