pan3793 commented on code in PR #5412:
URL: https://github.com/apache/kyuubi/pull/5412#discussion_r1360126112
##########
kyuubi-zookeeper/src/main/scala/org/apache/kyuubi/zookeeper/EmbeddedZookeeper.scala:
##########
@@ -31,12 +31,18 @@ class EmbeddedZookeeper extends
AbstractService("EmbeddedZookeeper") {
private var zks: ZooKeeperServer = _
private var serverFactory: NIOServerCnxnFactory = _
private var dataDirectory: File = _
+ private var dataLogDirectory: File = _
// TODO: Is it right in prod?
private val deleteDataDirectoryOnClose = true
private var host: String = _
override def initialize(conf: KyuubiConf): Unit = synchronized {
- dataDirectory = new File(conf.get(ZK_DATA_DIR))
+ val kyuubiHome = sys.env.getOrElse(KyuubiConf.KYUUBI_HOME, ".")
+ val kyuubiHomeWithDollar = "$" + KyuubiConf.KYUUBI_HOME
Review Comment:
@biangjuang for simple, what do you think about just changing the semantic
of the relative path, from `$PWD` to the `$KYUUBI_HOME`? Then we don't need to
handle the environment variable resolution (such interpret behavior may involve
security issues), just update the migration guide to mention it (I plan to cut
the 1.8.0 RC at late this week, if the PR complete before Tuesday, including
1.8 is fine)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
