pan3793 commented on code in PR #5412: URL: https://github.com/apache/kyuubi/pull/5412#discussion_r1360414639
########## docs/deployment/migration-guide.md: ########## @@ -23,6 +23,7 @@ Both Derby and SQLite are mainly for testing purposes, and they're not supposed to be used in production. To restore previous behavior, set `kyuubi.metadata.store.jdbc.database.type=DERBY` and `kyuubi.metadata.store.jdbc.url=jdbc:derby:memory:kyuubi_state_store_db;create=true`. +* Since Kyuubi 1.8, if the directory of the embedded zookeeper configuration is a relative path, it is resolved relative to `$KYUUBI_HOME` instead of `$PWD`. Review Comment: could we mention the exact configuration key in the sentence to avoid confusing users? ########## docs/deployment/migration-guide.md: ########## @@ -23,6 +23,7 @@ Both Derby and SQLite are mainly for testing purposes, and they're not supposed to be used in production. To restore previous behavior, set `kyuubi.metadata.store.jdbc.database.type=DERBY` and `kyuubi.metadata.store.jdbc.url=jdbc:derby:memory:kyuubi_state_store_db;create=true`. +* Since Kyuubi 1.8, if the directory of the embedded zookeeper configuration is a relative path, it is resolved relative to `$KYUUBI_HOME` instead of `$PWD`. Review Comment: could we mention the **exact configuration key** in the sentence to avoid confusing users? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
