pan3793 commented on code in PR #5653:
URL: https://github.com/apache/kyuubi/pull/5653#discussion_r1390598451
##########
kyuubi-server/src/main/scala/org/apache/kyuubi/server/KyuubiRestFrontendService.scala:
##########
@@ -219,9 +219,10 @@ class KyuubiRestFrontendService(override val serverable:
Serverable)
Option(AuthenticationFilter.getUserName).filter(_.nonEmpty).getOrElse("anonymous"))
}
- def getSessionUser(hs2ProxyUser: String): String = {
- val sessionConf = Option(hs2ProxyUser).filter(_.nonEmpty).map(proxyUser =>
- Map(KyuubiAuthenticationFactory.HS2_PROXY_USER ->
proxyUser)).getOrElse(Map())
+ def getSessionUser(proxyUser: String): String = {
+ // Internally, we use PROXY_USER to unify the key as proxyUser
Review Comment:
PROXY_USER: use the literal instead of variable name in comment
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
