mrtisttt commented on code in PR #5653:
URL: https://github.com/apache/kyuubi/pull/5653#discussion_r1390673413


##########
docs/client/rest/rest_api.md:
##########
@@ -449,13 +454,15 @@ Refresh the Hadoop configurations of the Kyuubi server.
 
 ### POST /admin/refresh/user_defaults_conf
 
-Refresh the [user defaults 
configs](../../configuration/settings.html#user-defaults) with key in format in 
the form of `___{username}___.{config key}` from default property file.
+Refresh the [user defaults 
configs](../../configuration/settings.html#user-defaults) with key in format in 
the form
+of `___{username}___.{config key}` from default property file.
 
 ### POST /admin/refresh/kubernetes_conf
 
 Refresh the kubernetes configs with key prefixed with `kyuubi.kubernetes` from 
default property file.
 
-It is helpful if you need to support multiple kubernetes contexts and 
namespaces, see [KYUUBI #4843](https://github.com/apache/kyuubi/issues/4843).
+It is helpful if you need to support multiple kubernetes contexts and 
namespaces,
+see [KYUUBI #4843](https://github.com/apache/kyuubi/issues/4843).

Review Comment:
   It may be caused by my using the mvn spotless:apply command, I will fix it 
immediately.



##########
kyuubi-server/src/main/scala/org/apache/kyuubi/server/KyuubiRestFrontendService.scala:
##########
@@ -219,9 +219,10 @@ class KyuubiRestFrontendService(override val serverable: 
Serverable)
       
Option(AuthenticationFilter.getUserName).filter(_.nonEmpty).getOrElse("anonymous"))
   }
 
-  def getSessionUser(hs2ProxyUser: String): String = {
-    val sessionConf = Option(hs2ProxyUser).filter(_.nonEmpty).map(proxyUser =>
-      Map(KyuubiAuthenticationFactory.HS2_PROXY_USER -> 
proxyUser)).getOrElse(Map())
+  def getSessionUser(proxyUser: String): String = {
+    // Internally, we use PROXY_USER to unify the key as proxyUser

Review Comment:
   Get it.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to