turboFei commented on code in PR #5711:
URL: https://github.com/apache/kyuubi/pull/5711#discussion_r1395296389
##########
kyuubi-common/src/main/scala/org/apache/kyuubi/config/KyuubiConf.scala:
##########
@@ -1231,6 +1231,22 @@ object KyuubiConf {
.checkValue(_ > 0, "must be positive number")
.createWithDefault(Duration.ofMinutes(5).toMillis)
+ val KUBERNETES_APPLICATION_STATE_FROM_CONTAINER: ConfigEntry[Boolean] =
+ buildConf("kyuubi.kubernetes.application.state.fromContainer")
+ .doc("If set to true then the application state will be retrieved from
the container " +
+ "instead of the pod.")
+ .version("1.8.1")
+ .booleanConf
+ .createWithDefault(false)
+
+ val KUBERNETES_APPLICATION_STATE_CONTAINERS: ConfigEntry[Set[String]] =
+ buildConf("kyuubi.kubernetes.application.state.containers")
+ .doc("A comma-separated list of container names to retrieve the
application state from.")
+ .version("1.8.1")
+ .stringConf
+ .toSet()
+ .createWithDefault(Set.empty)
Review Comment:
SGTM
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]