pan3793 commented on code in PR #5711:
URL: https://github.com/apache/kyuubi/pull/5711#discussion_r1395748708
##########
kyuubi-common/src/main/scala/org/apache/kyuubi/config/KyuubiConf.scala:
##########
@@ -1239,6 +1239,21 @@ object KyuubiConf {
.booleanConf
.createWithDefault(false)
+ val KUBERNETES_APPLICATION_STATE_FROM_CONTAINER: ConfigEntry[Boolean] =
+ buildConf("kyuubi.kubernetes.application.state.fromContainer")
Review Comment:
actually, there are other potential ways for app state judgement, e.g.
service, or CRD object, so I would suggest using an emum instead of bool for it.
```
kyuubi.kubernetes.application.state.from=[pod|contianer]
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
