beryllw commented on code in PR #6237:
URL: https://github.com/apache/kyuubi/pull/6237#discussion_r1547361045


##########
kyuubi-server/src/main/scala/org/apache/kyuubi/client/KyuubiSyncThriftClient.scala:
##########
@@ -141,9 +141,6 @@ class KyuubiSyncThriftClient private (
    * Lock every rpc call to send them sequentially
    */
   private def withLockAcquired[T](block: => T): T = 
Utils.withLockRequired(lock) {
-    if (engineConnectionClosed) {

Review Comment:
   > !protocol.getTransport.isOpen
   
   https://issues.apache.org/jira/browse/THRIFT-2530
   TIOStreamTransport's isOpen() always be true
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to