yaooqinn commented on code in PR #6237:
URL: https://github.com/apache/kyuubi/pull/6237#discussion_r1554832151
##########
kyuubi-server/src/main/scala/org/apache/kyuubi/operation/KyuubiOperation.scala:
##########
@@ -83,13 +82,9 @@ abstract class KyuubiOperation(session: Session) extends
AbstractOperation(sessi
MetricRegistry.name(OPERATION_FAIL, opType, errorType)))
val ke = e match {
case kse: KyuubiSQLException => kse
- case te: TTransportException
- if te.getType == TTransportException.END_OF_FILE &&
- StringUtils.isEmpty(te.getMessage) =>
- // https://issues.apache.org/jira/browse/THRIFT-4858
- KyuubiSQLException(
- s"Error $action $opType: Socket for ${session.handle} is
closed",
- e)
+ case te: TTransportException =>
+ warn(s"Error $action $opType: Socket for ${session.handle} is
closed", e)
+ KyuubiSQLException.connectionClosed(session.handle, e)
Review Comment:
I don't have a strong option here, both seem fine to me
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
