turboFei commented on code in PR #7033:
URL: https://github.com/apache/kyuubi/pull/7033#discussion_r2062554625
##########
kyuubi-server/src/main/scala/org/apache/kyuubi/operation/BatchJobSubmission.scala:
##########
@@ -212,6 +215,20 @@ class BatchJobSubmission(
metadata match {
case Some(metadata) if metadata.peerInstanceClosed =>
setState(OperationState.CANCELED)
+ case Some(metadata)
+ // in case it has been updated by peer kyuubi instance, see
KYUUBI-6278
Review Comment:
FYI:
https://github.com/apache/kyuubi/blob/70c03ef998bb695d62202f2378f3a09c5fcdfd83/kyuubi-server/src/main/scala/org/apache/kyuubi/operation/BatchJobSubmission.scala#L323-L325
For monitorBatchJob, it would get the currentApplicationInfo first, and does
not respect the metadata store application state.
##########
kyuubi-server/src/main/scala/org/apache/kyuubi/operation/BatchJobSubmission.scala:
##########
@@ -212,6 +215,20 @@ class BatchJobSubmission(
metadata match {
case Some(metadata) if metadata.peerInstanceClosed =>
setState(OperationState.CANCELED)
+ case Some(metadata)
+ // in case it has been updated by peer kyuubi instance, see
KYUUBI-6278
Review Comment:
FYI:
https://github.com/apache/kyuubi/blob/70c03ef998bb695d62202f2378f3a09c5fcdfd83/kyuubi-server/src/main/scala/org/apache/kyuubi/operation/BatchJobSubmission.scala#L323-L327
For monitorBatchJob, it would get the currentApplicationInfo first, and does
not respect the metadata store application state.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
