pan3793 commented on code in PR #7033:
URL: https://github.com/apache/kyuubi/pull/7033#discussion_r2062587117
##########
kyuubi-server/src/main/scala/org/apache/kyuubi/engine/ApplicationOperation.scala:
##########
@@ -85,15 +85,28 @@ trait ApplicationOperation {
tag: String,
proxyUser: Option[String] = None,
submitTime: Option[Long] = None): ApplicationInfo
+
+ /**
+ * Whether the application state can be persisted and retrieved after
finished.
+ * @return true if the application state can be persisted
+ */
+ def supportPersistedAppState: Boolean
}
object ApplicationState extends Enumeration {
type ApplicationState = Value
val PENDING, RUNNING, FINISHED, KILLED, FAILED, ZOMBIE, NOT_FOUND, UNKNOWN =
Value
- def isFailed(state: ApplicationState): Boolean = state match {
+ def isFailed(
+ state: ApplicationState,
+ appOperation: Option[ApplicationOperation]): Boolean = {
+ isFailed(state, appOperation.exists(_.supportPersistedAppState))
+ }
+
+ def isFailed(state: ApplicationState, supportPersistedAppState: Boolean):
Boolean = state match {
case FAILED => true
case KILLED => true
+ case NOT_FOUND => supportPersistedAppState
Review Comment:
```suggestion
case NOT_FOUND if supportPersistedAppState => true
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
