pan3793 commented on code in PR #7123: URL: https://github.com/apache/kyuubi/pull/7123#discussion_r2190096672
########## extensions/spark/kyuubi-spark-connector-hive/src/main/scala/org/apache/kyuubi/spark/connector/hive/read/HiveFileIndex.scala: ########## @@ -54,6 +54,13 @@ class HiveCatalogFileIndex( override def partitionSchema: StructType = table.partitionSchema + override def listFiles( Review Comment: I see, previously the method was not called, now it is passed to `OrcScanBuilder`, and finally will be called by `OrcScan#partitions`, overwriting is required so that filter pruning takes effect to avoid listing unnecessary partition files. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
