pan3793 commented on code in PR #7123:
URL: https://github.com/apache/kyuubi/pull/7123#discussion_r2190119961
##########
extensions/spark/kyuubi-spark-connector-hive/src/test/scala/org/apache/kyuubi/spark/connector/hive/HiveQuerySuite.scala:
##########
@@ -52,6 +52,15 @@ class HiveQuerySuite extends KyuubiHiveTest {
finally spark.sql(s"DROP TABLE $table")
}
+ def withTempPushFilterPartitionedTable(
Review Comment:
this does not look like an eligible encapsulation, let define
```
import org.apache.spark.sql.hive.kyuubi.connector.HiveBridgeHelper.Utils
abstract class KyuubiHiveTest extends QueryTest with Logging {
...
/**
* Drops table `tableName` after calling `f`.
*/
protected def withTable(tableNames: String*)(f: => Unit): Unit = {
Utils.tryWithSafeFinally(f) {
tableNames.foreach { name =>
spark.sql(s"DROP TABLE IF EXISTS $name")
}
}
}
...
}
```
##########
extensions/spark/kyuubi-spark-connector-hive/src/test/scala/org/apache/kyuubi/spark/connector/hive/HiveQuerySuite.scala:
##########
@@ -52,6 +52,15 @@ class HiveQuerySuite extends KyuubiHiveTest {
finally spark.sql(s"DROP TABLE $table")
}
+ def withTempPushFilterPartitionedTable(
Review Comment:
this does not look like an eligible encapsulation, let's define
```
import org.apache.spark.sql.hive.kyuubi.connector.HiveBridgeHelper.Utils
abstract class KyuubiHiveTest extends QueryTest with Logging {
...
/**
* Drops table `tableName` after calling `f`.
*/
protected def withTable(tableNames: String*)(f: => Unit): Unit = {
Utils.tryWithSafeFinally(f) {
tableNames.foreach { name =>
spark.sql(s"DROP TABLE IF EXISTS $name")
}
}
}
...
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
