1358035421 commented on PR #7158: URL: https://github.com/apache/kyuubi/pull/7158#issuecomment-3125251146
Hi @turboFei, Thank you for your feedback. I agree that from the Kyuubi service side, it's reasonable to restrict the session idle timeout set by clients, in order to protect the overall service stability. However, in the Spark scenario, the value of kyuubi.session.idle.timeout is actually determined by the first user who creates the Spark driver pod. So in practice, it is already user-controlled at that point. Given this, I think the logic to restrict or validate the session idle timeout should be handled specifically in class SparkSQLSessionManager private (name: String, spark: SparkSession) extends SessionManager(name) rather than changing the general behavior in the SessionManager base class. This way, we can address the Spark-specific behavior without affecting other engines or the general session management logic. Let me know if you agree with this direction, or if you have other suggestions! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
