turboFei commented on code in PR #7158:
URL: https://github.com/apache/kyuubi/pull/7158#discussion_r2237851318
##########
kyuubi-common/src/main/scala/org/apache/kyuubi/session/AbstractSession.scala:
##########
@@ -56,7 +56,12 @@ abstract class AbstractSession(
if (lastIdleTime > 0) System.currentTimeMillis() - _lastIdleTime else 0
}
- override val sessionIdleTimeoutThreshold: Long =
sessionManager.getConf.get(SESSION_IDLE_TIMEOUT)
+ override val sessionIdleTimeoutThreshold: Long = {
+ conf.get(SESSION_IDLE_TIMEOUT.key)
+ .map(_.toLong)
+ .getOrElse(
+ sessionManager.getConf.get(SESSION_IDLE_TIMEOUT))
+ }
Review Comment:
In my option, the engine session idle timeout is open for users, and the
kyuubi session idle timeout should be only set by kyuubi admin.
So, it is fine for me to ether apply this change to spark engine or other
engines.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
