yabola commented on code in PR #7207:
URL: https://github.com/apache/kyuubi/pull/7207#discussion_r2361687540
##########
extensions/spark/kyuubi-spark-lineage/src/main/scala/org/apache/kyuubi/plugin/lineage/helper/SparkSQLLineageParseHelper.scala:
##########
@@ -572,6 +572,24 @@ trait LineageParser {
p.cacheBuilder.tableName.toSeq)
}
+ case p: Filter =>
+ if (SparkContextHelper.getConf(
+ LineageConf.COLLECT_FILTER_CONDITION_TABLES_ENABLED)) {
Review Comment:
I am not sure if we need this conf, it isn't a major behavior change and are
always needed. We also found this issue before and have fixed it similar to
this, but forgot to report it. others LGTM.
PS: this will not affect column lineage, only affect the input tables,
because we set `parentColumnsLineage` as `ListMap[Attribute, AttributeSet]()`
and doesn't `mergeColumnsLineage`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
