lyne7-sc commented on code in PR #7207:
URL: https://github.com/apache/kyuubi/pull/7207#discussion_r2365025961


##########
extensions/spark/kyuubi-spark-lineage/src/main/scala/org/apache/kyuubi/plugin/lineage/helper/SparkSQLLineageParseHelper.scala:
##########
@@ -572,6 +572,24 @@ trait LineageParser {
               p.cacheBuilder.tableName.toSeq)
         }
 
+      case p: Filter =>
+        if (SparkContextHelper.getConf(
+            LineageConf.COLLECT_FILTER_CONDITION_TABLES_ENABLED)) {

Review Comment:
   I'm still not certain whether filter tables should be treated as upstream 
tables in all scenarios. Since the existing tests did not account for the 
existence of these tables, I added this conf to avoid breaking them.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to