Kami commented on code in PR #1983:
URL: https://github.com/apache/libcloud/pull/1983#discussion_r1581834223
##########
libcloud/compute/drivers/kubevirt.py:
##########
@@ -1231,3 +1719,151 @@ def ex_delete_service(self, namespace, service_name):
except Exception:
raise
return result.status in VALID_RESPONSE_CODES
+
+
+def _deep_merge_dict(source: dict, destination: dict) -> dict:
Review Comment:
It would be good to add some test cases for this function.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@libcloud.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
