cdfmlr commented on PR #1983: URL: https://github.com/apache/libcloud/pull/1983#issuecomment-2080812212
@Kami Thank you for the review. Indeed, the `create_node()` looks clumsy. I've actually started refactoring it, but recent higher priority tasks have delayed its completion. Also, at the moment, I'm unable to add more test cases due to these priority. However, there are some existing test cases for `_deep_merge_dict` and `_memory_in_MB` that I believe were copied from our other projects. I plan to incorporate these tests soon. Despite the problems with code readability and test coverage, we've been using this code in a production environment for several months. It has been performing well and handling a considerable number of situations that aren't covered by the test cases. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@libcloud.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
