[
https://issues.apache.org/jira/browse/LOG4J2-2475?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16648554#comment-16648554
]
ASF GitHub Bot commented on LOG4J2-2475:
----------------------------------------
Github user remkop commented on the issue:
https://github.com/apache/logging-log4j2/pull/218
I'm just not sure that this is a good idea.
It seems to make the code more brittle: if the code changes in the future
this may break something.
It seems safer to just clear the whole array.
That said, I can be convinced otherwise if there is a clear advantage. Can
you put this in perspective with some performance numbers? How much can be
gained by this change?
> Limit reusable event.clear parameter clearing to argsCount
> ----------------------------------------------------------
>
> Key: LOG4J2-2475
> URL: https://issues.apache.org/jira/browse/LOG4J2-2475
> Project: Log4j 2
> Issue Type: Improvement
> Components: Core
> Reporter: Carter Kozak
> Assignee: Carter Kozak
> Priority: Major
>
> Larger parameter arrays may make their way into log4j when passed into the
> logger directly. These may take longer to clear, despite only containing one
> or two parameters.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
