[
https://issues.apache.org/jira/browse/LOG4J2-2510?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16689365#comment-16689365
]
ASF GitHub Bot commented on LOG4J2-2510:
----------------------------------------
Github user cakofony commented on a diff in the pull request:
https://github.com/apache/logging-log4j2/pull/240#discussion_r234189607
--- Diff:
log4j-core/src/main/java/org/apache/logging/log4j/core/appender/rolling/RollingRandomAccessFileManager.java
---
@@ -156,7 +156,9 @@ public synchronized boolean closeOutputStream() {
flush();
if (randomAccessFile != null) {
try {
- randomAccessFile.close();
+ if (randomAccessFile != null) {
+ randomAccessFile.close();
+ }
--- End diff --
I think this was recently fixed on line 157, see
https://issues.apache.org/jira/browse/LOG4J2-2418
> RollingRandomAccessFileManager throws NPE in closeOutputStream on shutdown
> --------------------------------------------------------------------------
>
> Key: LOG4J2-2510
> URL: https://issues.apache.org/jira/browse/LOG4J2-2510
> Project: Log4j 2
> Issue Type: Bug
> Components: Appenders
> Affects Versions: 2.11.1
> Environment: Example config:
> status = TRACE
> dest = err
> name = testconfig
> appender.message.type = RollingRandomAccessFile
> appender.message.name = Message
> appender.message.append = true
> appender.message.immediateFlush = true
> appender.message.filePattern =
> ${sys:user.home}/log/%d\{MMddyyHH}00.Message.log
> appender.message.layout.type = PatternLayout
> appender.message.layout.pattern = %d\{yyyy.MM.dd HH:mm:ss.sss} %p [%t]
> %m%ex%n%n
> appender.message.policy.type = CronTriggeringPolicy
> appender.message.policy.schedule = 0 0 * * * ?
> appender.message.policy.evaluateOnStartup = true
> appender.message.filter.threshold.type = ThresholdFilter
> appender.message.filter.threshold.level = WARNING
> appender.message.strategy.type = DirectWriteRolloverStrategy
> appender.message.strategy.maxFiles = 999999
> rootLogger.level = ALL
> rootLogger.includeLocation = false
> rootLogger.appenderRef.message.ref = Message
>
> Reporter: Denis Kozlov
> Priority: Minor
>
> In configuration where RollingRandomAccessFile appender is used together with
> DirectWriteRolloverStrategy strategy and no messages got logged in a session
> I'm getting NullPointerException when closing the application.
> Exception call stack is:
> 2018-11-16 13:53:01,221 pool-1-thread-1 ERROR Caught exception executing
> shutdown hook null java.lang.NullPointerException
> at
> org.apache.logging.log4j.core.appender.rolling.RollingRandomAccessFileManager.closeOutputStream(RollingRandomAccessFileManager.java:168)
> at
> org.apache.logging.log4j.core.appender.OutputStreamManager.releaseSub(OutputStreamManager.java:136)
> at
> org.apache.logging.log4j.core.appender.rolling.RollingFileManager.releaseSub(RollingFileManager.java:266)
> at
> org.apache.logging.log4j.core.appender.AbstractManager.stop(AbstractManager.java:86)
> at
> org.apache.logging.log4j.core.appender.AbstractOutputStreamAppender.stop(AbstractOutputStreamAppender.java:142)
> at
> org.apache.logging.log4j.core.appender.RollingRandomAccessFileAppender.stop(RollingRandomAccessFileAppender.java:223)
> at
> org.apache.logging.log4j.core.config.AbstractConfiguration.stop(AbstractConfiguration.java:360)
> at org.apache.logging.log4j.core.LoggerContext.stop(LoggerContext.java:353)
> at org.apache.logging.log4j.core.LoggerContext$1.run(LoggerContext.java:281)
> at
> org.apache.logging.log4j.core.util.DefaultShutdownCallbackRegistry$RegisteredCancellable.run(DefaultShutdownCallbackRegistry.java:109)
> at
> org.apache.logging.log4j.core.util.DefaultShutdownCallbackRegistry.run(DefaultShutdownCallbackRegistry.java:74)
> at java.lang.Thread.run(Thread.java:745)
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
