[
https://issues.apache.org/jira/browse/LOG4NET-620?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16723970#comment-16723970
]
Dominik Psenner edited comment on LOG4NET-620 at 12/18/18 11:28 AM:
--------------------------------------------------------------------
I just answered some of your questions on the mailing list. I'm going to answer
these questions here so that future readers don't have to look up the [mailing
list
archive|http://mail-archives.apache.org/mod_mbox/logging-dev/201812.mbox/%3CCAES51_pVjW-sJ82XJHhVP2fzOb-mpceNvrZ7YQy0-R5XOM=q...@mail.gmail.com%3E]
but am not going to rephrase every word.
{quote}
1. Is log4net considering this or any similar appenders?
{quote}
The current implementation of the rolling file appender is one of the
components that "generates" the most issues. The answer here is therefore a
short and concise "YES".
{quote}
2. I need some critical feedbacks (e.g. naming, conventions, etc.) at this
stage. Am I supposed to submit my changes as a pull request or have them
discussed here?
{quote}
Github provides us with some good tools to review code contributions in the
form of pull requests. Working out a consenus of what should be implemented can
happen here or on the mailing list. For me both works fine as long as the
discussion is kept on topic. Via the mailing list I can usually give quick
feedbacks as long as I do not have to write essays on the phone. _laughing_
{quote}
3. Is there any coding convention guide for contributors?
{quote}
As you correctly pointed out, the contribution guideline is [in the source
code|https://github.com/apache/logging-log4net/blob/feature/RollingFileAppender-NG/CONTRIBUTING.md].
The latest revision of that document did not yet make it yet into the master
branch.
was (Author: nachbarslumpi):
I just answered some of your questions on the mailing list. I'm going to answer
these questions here so that future readers don't have to look up the [mailing
list
archive|http://mail-archives.apache.org/mod_mbox/logging-dev/201812.mbox/%3CCAES51_pVjW-sJ82XJHhVP2fzOb-mpceNvrZ7YQy0-R5XOM=q...@mail.gmail.com%3E]
but am not going to rephrase every word.
{quote}
1. Is log4net considering this or any similar appenders?
{quote}
The current implementation of the rolling file appender is one of the
components that "generates" the most issues. The answer here is therefore a
short and concise "YES".
{quote}
2. I need some critical feedbacks (e.g. naming, conventions, etc.) at this
stage. Am I supposed to submit my changes as a pull request or have them
discussed here?
{quote}
Github provides us with some good tools to review code contributions in the
form of pull requests. Working out a consenus of what should be implemented can
happen here or on the mailing list. For me both works fine as long as the
discussion is kept on topic. Via the mailing list I can usually give quick
feedbacks as long as I do not have to write essays on the phone. *laughing*
{quote}
3. Is there any coding convention guide for contributors?
{quote}
As you correctly pointed out, the contribution guideline is [in the source
code|https://github.com/apache/logging-log4net/blob/feature/RollingFileAppender-NG/CONTRIBUTING.md].
The latest revision of that document did not yet make it yet into the master
branch.
> RollingFileAppender extension that backs up only a last specified period
> (days, hours, etc.) proposal
> -----------------------------------------------------------------------------------------------------
>
> Key: LOG4NET-620
> URL: https://issues.apache.org/jira/browse/LOG4NET-620
> Project: Log4net
> Issue Type: Wish
> Components: Appenders
> Reporter: Farhan Nasim
> Priority: Minor
>
> A scenario occurs in many business cases where log files covering only a last
> specified period is needed (e.g. last 5 days, last 3 hours, etc.) Log4net
> doesn't provide any such appender; couldn't find any standard implementation
> either. I am writing one such appender (made some progress in fact) that
> derives from _RollingFileAppender_ and follows Log4net conventions.
> # Is Log4net considering this or any similar appenders?
> # I need some critical feedbacks (e.g. naming, conventions, etc.) at this
> stage. Am I supposed to submit my changes as a pull request or have them
> discussed here?
> # Is there any coding convention guide for contributors?
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
