mprusakov-rbc commented on issue #251: Remove garbage creation introduced by LOG4J2-2301 URL: https://github.com/apache/logging-log4j2/pull/251#issuecomment-453951428 First of all, thank you for spending time looking at my patch, I can confirm that I have tested it by patching this one file and allocations do disappear. Taking in account that the build has passed I have every confidence that the patch works. Frankly, I wasn't aware of the test mentioned above. If defaults are used garbage does get generated even in 2.11.0 by the disruptor so i can look into creating a generic test but then i will have to change the defaults which i am sure people will generally be unhappy about as let's be honest there is very little Java developers who care about garbage... Having said that, would it be possible to submit this patch and tackle the test separately? Many thanks in advance.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
