[ 
https://issues.apache.org/jira/browse/LOG4J2-2621?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16854131#comment-16854131
 ] 

Ralph Goers edited comment on LOG4J2-2621 at 6/2/19 10:34 PM:
--------------------------------------------------------------

With the annotation processor creating a Java source file the only thing that 
would need to be shaded would be the META-INF/services/ file. Using the 
ServiceLoader automatically makes it supportable for JPMS and I believe I 
already have that working, I am still working on OSGi. I would expect they 
would have handled as standard OSGi service implementations.


was (Author: [email protected]):
With the annotation processor creating a Java source file the only thing that 
would need to be shaded would be the META-INF/services/ file. Using the 
ServiceLoader automatically makes it supportable for JPMS, I am still working 
on OSGi. I would expect they would have handled as standard OSGi service 
implementations.

> Create log4j-plugins module and use ServiceLoader to load plugins
> -----------------------------------------------------------------
>
>                 Key: LOG4J2-2621
>                 URL: https://issues.apache.org/jira/browse/LOG4J2-2621
>             Project: Log4j 2
>          Issue Type: Task
>          Components: Plugins
>    Affects Versions: 3.0.0
>            Reporter: Ralph Goers
>            Assignee: Ralph Goers
>            Priority: Major
>
> As part of splitting log4j 2 into smaller components it is clear that the 
> plugin system, and especially the annotation processor, could be split into a 
> separate module. Also, to be more compliant with the Java module system it 
> might be beneficial to generate a Class file with all the plugin information 
> instead of the data file currently being generated.
> Moving the plugins to a separate module is going to impact anyone who has 
> created a Log4j 2 plugin as the package for the plugin annotations must 
> change.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to