[GitHub] [logging-log4j2] rgoers commented on a change in pull request #394: LOG4J2-2892 - Add support for newline delimited messages in GelfLayout

[GitBox]

rgoers commented on a change in pull request #394:
URL: https://github.com/apache/logging-log4j2/pull/394#discussion_r466145003



##########
File path: 
log4j-core/src/test/java/org/apache/logging/log4j/core/layout/GelfLayoutTest.java
##########
@@ -222,37 +224,42 @@ private void testCompressedLayout(final CompressionType 
compressionType, final b
 
     @Test
     public void testLayoutGzipCompression() throws Exception {
-        testCompressedLayout(CompressionType.GZIP, true, true, HOSTNAME, 
false);
+        testCompressedLayout(CompressionType.GZIP, true, true, HOSTNAME, 
false, false);
     }
 
     @Test
     public void testLayoutNoCompression() throws Exception {
-        testCompressedLayout(CompressionType.OFF, true, true, HOSTNAME, false);
+        testCompressedLayout(CompressionType.OFF, true, true, HOSTNAME, false, 
false);
     }
 
     @Test
     public void testLayoutZlibCompression() throws Exception {
-        testCompressedLayout(CompressionType.ZLIB, true, true, HOSTNAME, 
false);
+        testCompressedLayout(CompressionType.ZLIB, true, true, HOSTNAME, 
false, false);
     }
 
     @Test
     public void testLayoutNoStacktrace() throws Exception {
-        testCompressedLayout(CompressionType.OFF, false, true, HOSTNAME, 
false);
+        testCompressedLayout(CompressionType.OFF, false, true, HOSTNAME, 
false, false);
     }
 
     @Test
     public void testLayoutNoThreadContext() throws Exception {
-        testCompressedLayout(CompressionType.OFF, true, false, HOSTNAME, 
false);
+        testCompressedLayout(CompressionType.OFF, true, false, HOSTNAME, 
false, false);
     }
 
     @Test
     public void testLayoutNoHost() throws Exception {
-        testCompressedLayout(CompressionType.OFF, true, true, null, false);
+        testCompressedLayout(CompressionType.OFF, true, true, null, false, 
false);
     }
 
     @Test
     public void testLayoutNullDelimiter() throws Exception {
-        testCompressedLayout(CompressionType.OFF, false, true, HOSTNAME, true);
+        testCompressedLayout(CompressionType.OFF, false, true, HOSTNAME, true, 
false);
+    }
+
+    @Test
+    public void testLayoutNewLineDelimiter() throws Exception {
+        testCompressedLayout(CompressionType.OFF, false, true, HOSTNAME, 
false, true);

Review comment:
       Please include a test that includes the stack trace.

##########
File path: 
log4j-core/src/test/java/org/apache/logging/log4j/core/layout/GelfLayoutTest.java
##########
@@ -222,37 +224,42 @@ private void testCompressedLayout(final CompressionType 
compressionType, final b
 

Review comment:
       I don't see any code added to validate that the newline is present.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org