Fabricc commented on a change in pull request #462: URL: https://github.com/apache/logging-log4j2/pull/462#discussion_r567292483
########## File path: log4j-layout-template-json/src/test/java/org/apache/logging/log4j/layout/template/json/JsonTemplateLayoutAdditionalFieldTestProperties.java ########## @@ -0,0 +1,71 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache license, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the license for the specific language governing permissions and + * limitations under the license. + */ +package org.apache.logging.log4j.layout.template.json; + +import org.apache.logging.log4j.Logger; +import org.apache.logging.log4j.core.LoggerContext; +import org.apache.logging.log4j.junit.LoggerContextSource; +import org.apache.logging.log4j.junit.Named; +import org.apache.logging.log4j.layout.template.json.util.JsonReader; +import org.apache.logging.log4j.test.appender.ListAppender; +import org.assertj.core.api.Assertions; +import org.junit.jupiter.api.Test; + +import java.util.Arrays; +import java.util.Collections; +import java.util.List; +import java.util.Map; + +@LoggerContextSource("log4j2-properties-with-arrays.properties") +class JsonTemplateLayoutAdditionalFieldTestProperties { Review comment: Thank you for the feedback! I tried to stick to this example but I had some issues with the LoggerContextSource. It seems that every test gets only the first LoggerContextSource parsed. I tried to reconfigure the context and to programmatically change it but didn't work out. I also tried to use LoggerContextRule but that too didn't work as expect. Therefore I decided to create a common helper method and keep the classes separated but I have to admit, it doesn't look as concise as your suggestion. What do you think? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
