[ 
https://issues.apache.org/jira/browse/LOG4J2-2955?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17447127#comment-17447127
 ] 

Ralph Goers commented on LOG4J2-2955:
-------------------------------------

There is a unit test that tests for the reported problem and it passes. 

The PR provided by [~spannjp] changes the behavior of the parsing by 

* converting commas to periods unless a period is also present
* throwing an exception for any abnormal condition
* No longer accepts a default value.
* Accepts non-integer values such as 1.5GB.

None of the above items were identified as a problem in this Jira issue. This 
issue will be closed. I may create a new issue to track allowing non-integer 
values but I don't believe the other 3 changes are required or desirable.



> SizeBasedTriggeringPolicy with space between the number and the unit does not 
> work e.g. 1 MB does not work but 1MB does work.
> -----------------------------------------------------------------------------------------------------------------------------
>
>                 Key: LOG4J2-2955
>                 URL: https://issues.apache.org/jira/browse/LOG4J2-2955
>             Project: Log4j 2
>          Issue Type: Bug
>          Components: Appenders
>    Affects Versions: 2.12.0
>            Reporter: Deepak Khopade
>            Priority: Major
>
> Hello There,
> Recently we found that when we add an appender for {{RollingFile}} , using 
> {{<SizeBasedTriggeringPolicy size="1 MB"/>}}  does not work; meaning when 
> {{1<space>MB}} and when there is no space i.e. {{<SizeBasedTriggeringPolicy 
> size="1MB"/>}} it works as expected.
> Any thoughts if it's a bug?
> Thanks,
> Deepak



--
This message was sent by Atlassian Jira
(v8.20.1#820001)

Reply via email to