yueki1993 commented on code in PR #924:
URL: https://github.com/apache/logging-log4j2/pull/924#discussion_r894062873
##########
log4j-1.2-api/src/test/java/org/apache/log4j/config/PropertiesConfigurationTest.java:
##########
@@ -129,6 +129,28 @@ public void testConsoleAppenderLevelRangeFilter() throws
Exception {
assertEquals(Level.ALL, customFilterReal.getMinLevel());
final LevelRangeFilter defaultFilter = (LevelRangeFilter)
filters[1];
assertEquals(Level.TRACE, defaultFilter.getMinLevel());
+
+ final ListAppender legacyAppender = (ListAppender)
((AppenderAdapter.Adapter) appender).getAppender();
+ final Logger logger =
LogManager.getLogger(PropertiesConfigurationTest.class);
+
+ // denied???
+ logger.trace("TRACE");
+ assertEquals(0, legacyAppender.getEvents().size());
+ // denied???
+ logger.debug("DEBUG");
+ assertEquals(0, legacyAppender.getEvents().size());
+ // denied???
+ logger.info("INFO");
+ assertEquals(0, legacyAppender.getEvents().size());
+ // denied???
+ logger.warn("WARN");
+ assertEquals(0, legacyAppender.getEvents().size());
+ // denied???
+ logger.error("ERROR");
+ assertEquals(0, legacyAppender.getEvents().size());
+ // denied???
+ logger.fatal("FATAL");
+ assertEquals(0, legacyAppender.getEvents().size());
Review Comment:
this test fails in ba48d2b, so I took a look here.
(bac3547d9aa79f8e76e1cc3efa8254ff2e053510)
Under this setting, this rejects all output logs.
I believe we expect here we get all messages accepted because we set
`levelMin=ALL`.
https://github.com/yueki1993/logging-log4j1/commit/e104a91fdfc9cea5c5c05bdb74d90a7236665edf
(see: https://issues.apache.org/jira/browse/LOG4J2-2315)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@logging.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
