[GitHub] [logging-log4cxx] rm5248 commented on a diff in pull request #132: Use std::make_shared to create std::shared_ptr instances

[GitBox]

rm5248 commented on code in PR #132:
URL: https://github.com/apache/logging-log4cxx/pull/132#discussion_r974276552


##########
src/main/include/log4cxx/helpers/threadutility.h:
##########
@@ -69,15 +69,14 @@ LOG4CXX_PTR_DEF(ThreadUtility);
 class LOG4CXX_EXPORT ThreadUtility
 {
        private:
-               ThreadUtility();
-
                log4cxx::helpers::ThreadStartPre preStartFunction();
                log4cxx::helpers::ThreadStarted threadStartedFunction();
                log4cxx::helpers::ThreadStartPost postStartFunction();
 
                LOG4CXX_DECLARE_PRIVATE_MEMBER_PTR(priv_data, m_priv)
 
        public:
+               ThreadUtility();

Review Comment:
   It seems like this would break the singleton aspect of this class, do we 
really want it to have a public constructor?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@logging.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org