[
https://issues.apache.org/jira/browse/LOG4J2-3601?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17606783#comment-17606783
]
Piotr Karwasz edited comment on LOG4J2-3601 at 9/19/22 10:09 PM:
-----------------------------------------------------------------
[~ctubbsii],
The reason I didn't put {{log4j-core}} as runtime dependency for
{{log4j-slf4j2-impl}} is for consistency with {{log4j-to-slf4j}} that does not
list {{logback-classic}} as runtime dependency.
However I agree that most users will use {{log4j-slf4j2-impl}} to bind SLF4J to
Log4j2 Core and, although I might not like it, this change should be
implemented.
IMHO if you plan to ship Apache Accumulo with Log4j2 Core as its logging
backend, you should declare a runtime dependency on `log4j-core`. You might
also consider coding against the Log4j2 API directly as it has many advantages
over SLF4J (cf. [Remko's answer on
SO|https://stackoverflow.com/a/41500347/11748454]), e.g. no temporary arrays if
your message has more than 2 arguments.
was (Author: pkarwasz):
[~ctubbsii],
The reason I didn't put {{log4j-core}} as runtime dependency for
{{log4j-slf4j2-impl}} is for consistency with {{log4j-to-slf4j}} that does not
list {{logback-classic}} as runtime dependency.
However I agree that most users will use {{log4j-slf4j2-impl}} to bind SLF4J to
Log4j2 Core and, although I might not like it, this change should be
implemented.
IMHO software that ships with Log4j2 Core as its logging backend, should
declare a runtime dependency on `log4j-core`.
> log4j-slf4j2: change of dependency scope for log4j-core
> -------------------------------------------------------
>
> Key: LOG4J2-3601
> URL: https://issues.apache.org/jira/browse/LOG4J2-3601
> Project: Log4j 2
> Issue Type: Improvement
> Components: SLF4J Bridge
> Affects Versions: 2.19.0
> Reporter: Andy Seaborne
> Priority: Major
>
> The artifact {{log4j-slf4j-impl}} has a scope=runtime dependency on
> log4j-core. {{log4j-slf4j18-impl}} similarly had scope=runtime.
> The artifact {{log4j-slf4j2-impl}} has a scope=test dependency on log4j-core.
> This changed as part of [commit
> 8f63620875|https://github.com/apache/logging-log4j2/pull/1024/files#diff-d3ba9956a9f81420d0be3d69477a05b505746272d548ab17404aa47f3e5946b0]
> although it seems to be unrelated.
> It makes switching over more of a bump. Previously just depending on
> {{log4j-slf4j-impl}} was enough.
> Please switch back to a scope=runtime dependency for {{log4j-slf4j2-impl}}.
> Example: we (Apache Jena) use slf4j in the main code base, and select log4j
> when it needed for binaries tests so we have multiple places where the
> dependency happens. We can change - but this may be a user experience for
> others as well.
> {noformat}
> [INFO] +- org.apache.logging.log4j:log4j-slf4j-impl:jar:2.18.0:compile
> [INFO] | +- org.apache.logging.log4j:log4j-api:jar:2.18.0:compile
> [INFO] | \- org.apache.logging.log4j:log4j-core:jar:2.18.0:runtime
> {noformat}
> {noformat}
> [INFO] +- org.apache.logging.log4j:log4j-slf4j2-impl:jar:2.19.0:compile
> [INFO] | \- org.apache.logging.log4j:log4j-api:jar:2.19.0:compile
> {noformat}
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
