vy commented on PR #1683: URL: https://github.com/apache/logging-log4j2/pull/1683#issuecomment-1757031463
@Karthi1711, I am fine with these changes; except the `length()`. Let's keep the opened up methods to minimum: `createCompressAction()` and `getExtension()` are fine, but we don't need `length()`, which is accessible by `getExtension().length()` anyway. I will 1. merge the changes 2. make `length()` package-private again 3. add a changelog entry -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@logging.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
