rm5248 commented on PR #271: URL: https://github.com/apache/logging-log4cxx/pull/271#issuecomment-1758684795
The segfault on crash is rather sporadic, you can run the following to stress it: ``` while [ 1 ]; do make test ARGS="-R multithreadtest"; if [ $? -ne 0 ]; then break; fi; done; ``` The testing that I have done does show that it works fine, without any memory leaks as I was expecting which is rather surprising to me. Some of the statics that are declared do have strings or maps in them, which do allocate memory internally, so I was expecting that memory to be leaked. I checked with both valgrind and lsan(with `-fsanitize=leak`). Perhaps it is not picking up on leaks that are caused by statically allocated memory. This looks good to me; if it fixes the "my program crashes because I'm logging after calling `exit()`" problem with no bad side effects it sounds good to me and could be something that we enable by default. Any thoughts? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@logging.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
