vy opened a new pull request, #77:
URL: https://github.com/apache/logging-parent/pull/77
This PR implements #69 requesting the switch from `bnd:jar` to
`bnd:bnd-process`.
### Implementation notes
- When run against [logging-log4j2](apache/logging-log4j2),
(`spotbugs-maven-plugin` started crashing with switch to `bnd:bnd-process`.
Setting `fork` to `false` fixed the problem. Though this interestingly caused
new bug discoveries by `spotbugs:spotbugs` goal and this only happened for
`2.x` branch. `main` did not observe any `spotbugs:spotbugs` anomalies after
the switch. All new Spotbugs findings in `2.x` are fixed in
apache/logging-log4j2@15fddad1925645d3484e31ad171a1ff6487a1e46 and
apache/logging-log4j2@9f7455a77ed15a36c2ad34a07b78361e3e889866.
- Set `useModulePath` to `false` for `maven-compiler-plugin` (with
`default-testCompile` execution ID), `maven-surefire-plugin`, and
`maven-failsafe-plugin`. This was already more or less the norm in
[logging-log4j2](apache/logging-log4j2).
### Results
- `2.x` branch of [logging-log4j2](apache/logging-log4j2) compiles and one
can run tests in IntelliJ IDEA without problems.
- `main` branch of [logging-log4j2](apache/logging-log4j2)
- does *not* compile – `<extensions>true</extensions>` needs to be removed
from existing `bnd-maven-plugin` overrides.
- IntelliJ IDEA build fails (on `log4j-core`) with `module not found:
org.jctools.core`, `module not found: org.fusesource.jansi`, etc. messages.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
