ppkarwasz commented on code in PR #2112:
URL: https://github.com/apache/logging-log4j2/pull/2112#discussion_r1432448005
##########
log4j-jpl/pom.xml:
##########
@@ -65,29 +65,26 @@
</dependency>
</dependencies>
- <profiles>
- <profile>
- <id>java8-tests</id>
- <activation>
- <property>
- <name>env.CI</name>
- <value>true</value>
- </property>
- </activation>
- <build>
- <plugins>
- <plugin>
- <groupId>org.apache.maven.plugins</groupId>
- <artifactId>maven-surefire-plugin</artifactId>
- <configuration combine.self="override">
- <reuseForks>false</reuseForks>
- <systemPropertyVariables>
- <java.awt.headless>true</java.awt.headless>
- </systemPropertyVariables>
- </configuration>
- </plugin>
- </plugins>
- </build>
- </profile>
- </profiles>
+ <build>
+ <plugins>
+ <plugin>
+ <groupId>org.apache.maven.plugins</groupId>
+ <artifactId>maven-surefire-plugin</artifactId>
+ <executions>
+ <!-- Uses a different id than `default-test` to ignore the
`java8-tests` profile -->
+ <execution>
+ <id>run-tests</id>
+ <goals>
+ <goal>test</goal>
+ </goals>
+ </execution>
+ <execution>
+ <id>default-test</id>
+ <phase>none</phase>
Review Comment:
I prefer if this configuration isn't executed at all.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@logging.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
