grobmeier commented on code in PR #2356:
URL: https://github.com/apache/logging-log4j2/pull/2356#discussion_r1517611811
##########
src/site/asciidoc/index.adoc:
##########
@@ -34,6 +36,20 @@ The project is actively maintained by a link:team.html[team]
of several voluntee
We share below some highlights from Log4j features.
+[source,java]
+----
+import java.util.logging.LogManager;
+import java.util.logging.Logger;
+
+class Application {
+ private static final Logger logger =
LogManager.getLogger(Application.class);
+
+ public void action() {
+ logger.info("Hello, World!");
Review Comment:
Personally, I always make exceptions for logger. All this uppercase LOGGER
things make the code unreadable and ugly for my taste. I am also not sure why
it would be better to remove the name of the logger, I am curious about this. I
have learned otherwise.
We can discuss this kind of code style in depth, but I suggest not for
merging this PR otherwise it will be blocked forever
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@logging.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
